chore(demo): remove prisma/seed.demo.ts (lives in vectorflow-demo-ops)#189
Merged
TerrifiedBug merged 1 commit intomainfrom Apr 27, 2026
Merged
chore(demo): remove prisma/seed.demo.ts (lives in vectorflow-demo-ops)#189TerrifiedBug merged 1 commit intomainfrom
TerrifiedBug merged 1 commit intomainfrom
Conversation
…emo-ops) Demo seed data is an ops concern, not an app concern. The vectorflow-demo-ops repo already owns the demo lifecycle: scripts/seed.sql + scripts/nightly-reset.sh + compose.yaml + a cron entry that does compose-down/up + migrate + psql-seed + restart-web on a 03:00 UTC schedule. Adding prisma/seed.demo.ts to the app repo in #188 duplicated work that already lives where it belongs and put a destructive script (rm + rebuild all data scoped to the demo user) into the application repository where it has no callers — the demo deployment uses seed.sql via psql, not the seed:demo npm script. This reverts #188's seed.demo.ts and the seed:demo package.json script. A follow-up against vectorflow-demo-ops will port the richer dataset (3 environments, 12 nodes, 8 pipelines, 5-min PipelineMetric granularity, 14 anomaly events, 5 cost recommendations) into seed.sql so the demo deployment actually benefits from that work.
github-actions
Bot
added
ignore-for-release
dependencies
Contributor
Greptile SummaryThis PR reverts Confidence Score: 5/5Safe to merge — pure deletion with no callers or CI references affected. Both changed files are a straightforward removal: a dead script file and its package.json entry. No CI workflows reference the deleted script, no other code imports or calls it, and the PR description correctly identifies that the demo lifecycle lives in a separate ops repo. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["#188 added prisma/seed.demo.ts\n+ seed:demo script"] -->|"This PR (#189) reverts"| B["prisma/seed.demo.ts DELETED\nseed:demo removed from package.json"]
B --> C["Demo seed data responsibility"]
C --> D["vectorflow-demo-ops\nscripts/seed.sql\nscripts/nightly-reset.sh\n03:00 UTC cron"]
style A fill:#f87171,color:#fff
style B fill:#4ade80,color:#000
style D fill:#60a5fa,color:#fff
Reviews (1): Last reviewed commit: "chore(demo): remove seed.demo.ts from ap..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the seed script added in #188. Demo seed data is an ops concern that already has a home: `vectorflow-demo-ops` owns the demo lifecycle via `scripts/seed.sql` + `scripts/nightly-reset.sh` + a 03:00 UTC cron entry that does `compose down -v` → migrate → `psql < seed.sql` → restart web.
Adding `prisma/seed.demo.ts` to this repo duplicated work that already lives where it belongs and put a destructive script (wipes the demo user and cascades) into the app codebase with no callers — the demo deployment doesn't use `pnpm seed:demo`, it uses `seed.sql` via psql.
Changes
Follow-up
A separate PR against `vectorflow-demo-ops` will port the richer dataset that #188 was producing (3 environments, 12 nodes, 8 pipelines, 5-min `PipelineMetric` granularity, 14 anomaly events, 5 cost recommendations) into `seed.sql` so the demo deployment actually benefits from the work. Postgres `generate_series` handles the time-series synthesis natively, so the SQL form is a clean fit.
Test plan